New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nheko: 0.6.2 -> 0.6.3 #55472

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@dotlambda
Copy link
Member

dotlambda commented Feb 9, 2019

Motivation for this change

https://github.com/Nheko-Reborn/nheko/releases/tag/v0.6.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog

Ekleog approved these changes Feb 9, 2019

Copy link
Member

Ekleog left a comment

LGTM! Good to see a fork of the project start again :)

@dotlambda

This comment has been minimized.

Copy link
Member Author

dotlambda commented Feb 12, 2019

@fpletz ignored this: e2460a9

@dotlambda dotlambda closed this Feb 12, 2019

@dotlambda dotlambda reopened this Feb 12, 2019

@dotlambda dotlambda force-pushed the dotlambda:nheko-0.6.3 branch from a49a052 to e79c1f5 Feb 12, 2019

@dotlambda dotlambda merged commit c7c9111 into NixOS:master Feb 12, 2019

@fpletz

This comment has been minimized.

Copy link
Member

fpletz commented Feb 12, 2019

Sorry, didn't notice this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment