Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0 #55475

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@Moredread
Copy link
Contributor

commented Feb 9, 2019

Motivation for this change

It seems likely to me that there will be a new stable release of slic3r-prusa3d soon. There have been quite a few changes, esp. the rewrite of components in Perl.

To avoid duplicated work, I already create this PR with a working update for 1.42.0-alpha5, so others can build on it.

Updated to the latest stable version, 2.0.0.

The slic3r-prusa3d package was renamed by upstream to PrusaSlicer with
the 2.0.0 release to reduce confusion with the slic3r package.

cc @thorstenweber83

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.0 -> 1.42.0-alpha5 (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-alpha5 Feb 12, 2019

@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-alpha5 (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-beta Mar 21, 2019

@Moredread Moredread force-pushed the Moredread:slic3r branch from 1f40e76 to 11074a9 Mar 21, 2019

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@GrahamcOfBorg build slic3r-prusa3d

@Moredread Moredread force-pushed the Moredread:slic3r branch 2 times, most recently from 701dc34 to 7fc5d5d Mar 25, 2019

@Moredread Moredread force-pushed the Moredread:slic3r branch from 7fc5d5d to ca84080 Apr 17, 2019

@Moredread Moredread force-pushed the Moredread:slic3r branch from ca84080 to ddd7600 May 17, 2019

@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-beta (WIP) prusa-slicer: renamed from slic3r-prusa3d and 1.41.0 -> 2.0.0-rc May 17, 2019

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

The package was renamed to PrusaSlicer by upstream.

I'm not sure what we should call it. PrusaSlicer is the official name but the binary is named prusa-slicer.

@thorstenweber83

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

The manual says not to use uppercase letter for the attribute name: https://nixos.org/nixpkgs/manual/#sec-package-naming

So prusa-slicer is the right way to go, I think.

@Moredread Moredread force-pushed the Moredread:slic3r branch from 1cca23a to 0a9375d May 21, 2019

@Moredread Moredread changed the title (WIP) prusa-slicer: renamed from slic3r-prusa3d and 1.41.0 -> 2.0.0-rc prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0 May 21, 2019

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

Updated to the latest stable version, 2.0.0.

It is ready for merge now. :)

@thorstenweber83 @mweinelt

@mweinelt

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Builds and runs, thanks!

@thorstenweber83

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Yes, looks good! thank you!

@ArdaXi

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

I added these changes into my overlay and ran into a crash issue in the GUI. I'm not sure if it's because of upstream changes or issues with the package, so I'm linking it here just in case:

prusa3d/PrusaSlicer#2360

@mweinelt

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

I see GUI freezes when I leave the window idling for some minutes in the background with some model loaded and sliced. No particular error relates to that afaict.

stdout/stderr
[nix-shell:~/.cache/nix-review/pr-55475]$ prusa-slicer 
04:43:13 PM: Debug: Failed to connect to session manager: SESSION_MANAGER environment variable not defined
Multisample enabled

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:13.674: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:13.674: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.269: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.269: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.282: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.450: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.450: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.469: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.469: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.471: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.798: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.798: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.852: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.853: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-WARNING **: 16:43:20.369: Could not find the icon 'application-xml'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
	http://icon-theme.freedesktop.org/releases

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.770: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.770: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.781: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.782: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.782: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.557: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.558: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.558: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.559: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.376: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.377: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.878: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.878: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.636: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.636: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.647: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.647: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.648: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed
prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0
The slic3r-prusa3d package was renamed by upstream to PrusaSlicer with
the 2.0.0 release to reduce confusion with the slic3r package.

We compile against wxGTK 3.0, as with 3.1 the application crashes (see

@Moredread Moredread force-pushed the Moredread:slic3r branch from 0a9375d to 0ee35c5 May 26, 2019

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

I've changed the PR to compile against wxGTK 3.0, as I only see the bug in prusa3d/PrusaSlicer#2360 with 3.1.

@mweinelt @ArdaXi does that work for you?

@mweinelt

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

Yes, that fixes "Add instance" for me.

@ArdaXi

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Confirmed, the new version does not display this behaviour. Thanks!

@baracoder

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Tested yesterday with nix-env -iA prusa-slicer -f https://github.com/Moredread/nixpkgs/archive/slic3r.tar.gz
Everything expect add instance worked.
To get custom profiles from the older version, you need to use Export config bundle from slic3r-pe and imported it to prusa-slicer

@ArdaXi

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

On a hunch I updated wxWidgets to 3.1.2 and the issue disappeared as well. It might be worth upgrading wxWidgets, considering 3.1.2 came out in December, then this package can be built against 3.1 as well.

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

On a hunch I updated wxWidgets to 3.1.2 and the issue disappeared as well. It might be worth upgrading wxWidgets, considering 3.1.2 came out in December, then this package can be built against 3.1 as well.

Do you want to create the PR for wxWidgets 3.1.2? I think it would be better to review it on it's own terms, as I guess there a few packages that depend on it that need to be checked.

Should we wait before we merge this PR, or can we merge the version with wxGTK 3.0?

@ArdaXi ArdaXi referenced this pull request May 28, 2019
1 of 10 tasks complete
@ArdaXi

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

I feel like the wxGTK update is a pretty significant PR which might take a while to merge. I don't personally think that there's a huge loss in having this PR build against 3.0, so I would vote to go ahead and update later.

@thorstenweber83

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

I also think we shouldn't wait for wxGTK to be updated. Let's just move to 3.1.2 later when the pull request is through.

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

In that case I think we are basically ready for merging. :)

Can somebody with commit access please remove the WIP tag?

@Moredread

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@GrahamcOfBorg build prusa-slicer

@nixos-discourse

This comment has been minimized.

Copy link

commented Jun 11, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/14

@teto

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

trusting previous reviews

@teto teto merged commit dd14c5b into NixOS:master Jun 11, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
prusa-slicer on aarch64-linux Success
Details
prusa-slicer on x86_64-linux Success
Details

@Moredread Moredread deleted the Moredread:slic3r branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.