Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: 2.31.1 -> 2.32 #55485

Closed
wants to merge 1 commit into from

Conversation

@matthewbauer
Copy link
Member

matthewbauer commented Feb 9, 2019

Fixes #51293.

Fixes #51293.
@matthewbauer

This comment has been minimized.

Copy link
Member Author

matthewbauer commented Feb 10, 2019

I am getting some unexplained errors when using this. Probably better to figure those out before merging.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Feb 12, 2019

cc #55165 FWIW, likely same but haven't checked :).

@dtzWill dtzWill changed the title binutils: 2.30 -> 2.32 binutils: 2.31.1 -> 2.32 Feb 12, 2019
# Remove gold-symbol-visibility patch when updating, the proper fix
# is now upstream.
# https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=330b90b5ffbbc20c5de6ae6c7f60c40fab2e7a4f;hp=99181ccac0fc7d82e7dabb05dc7466e91f1645d3
version = "2.31.1";

This comment has been minimized.

Copy link
@dtzWill

dtzWill Feb 12, 2019

Contributor

may wish to revise commit message since this starts with 2.31.1 not 2.30.

@dtzWill dtzWill mentioned this pull request Feb 12, 2019
1 of 10 tasks complete
@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Feb 12, 2019

@matthewbauer

This comment has been minimized.

Copy link
Member Author

matthewbauer commented Feb 16, 2019

@matthewbauer

This comment has been minimized.

Copy link
Member Author

matthewbauer commented Feb 21, 2019

@dtzWill here is the error I get building coreutils on x86_64-linux with this change:

mkdir: cannot change permissions of 'parent/sub': Function not implemented
parent/sub: expected d-wx--x-w-, got d-wx----w-
mkdir: cannot change permissions of 'parent/sub': Function not implemented
parent/sub: expected d-wx--x-w-, got d-wx----w-
FAIL tests/mkdir/perm.sh (exit status: 1)

It could be the machine though. I'd be interested in seeing if anyone else has the same issue.

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Feb 22, 2019

Have you considered using later 2.31 branch? (no tarballs unfortunately) It happened multiple times for us that fresh binutils caused lots of failures.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.