Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonar-scanner-bin: init at 3.3.0.1492 #55558

Merged
merged 1 commit into from Oct 23, 2020
Merged

sonar-scanner-bin: init at 3.3.0.1492 #55558

merged 1 commit into from Oct 23, 2020

Conversation

@peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Feb 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterromfeldhk
Copy link
Contributor Author

@peterromfeldhk peterromfeldhk commented Feb 11, 2019

i have no idea how to build this from source :(

even for the bin version i have some questions:
1. it comes with jre shipped, i guess i should instead propagate jre?
2. it has some config, should i make it a service where you can configure it?

@peterromfeldhk
Copy link
Contributor Author

@peterromfeldhk peterromfeldhk commented Feb 11, 2019

also issue on linux :(

[nix-shell:~]$ sonar-scanner -h
/nix/store/xgs83qivcnl370wdypbazj0zw9bls51j-sonar-scanner-bin-3.3.0.1492/bin/sonar-scanner: line 59: /nix/store/xgs83qivcnl370wdypbazj0zw9bls51j-sonar-scanner-bin-3.3.0.1492/jre/bin/java: No such file or directory

though its there... i guess because that server is a bit stricter

[nix-shell:~]$ ls -lah /nix/store/xgs83qivcnl370wdypbazj0zw9bls51j-sonar-scanner-bin-3.3.0.1492/jre/bin/java
-r-xr-xr-x 2 root root 7.6K Jan  1  1970 /nix/store/xgs83qivcnl370wdypbazj0zw9bls51j-sonar-scanner-bin-3.3.0.1492/jre/bin/java

not using the shipped jre anymore

@peterromfeldhk peterromfeldhk changed the title WIP: sonar-scanner-bin: init at 3.3.0.1492 sonar-scanner-bin: init at 3.3.0.1492 Feb 12, 2019
@peterromfeldhk
Copy link
Contributor Author

@peterromfeldhk peterromfeldhk commented Feb 12, 2019

just had successful run with it on OSX :) need to try it on linux

@peterromfeldhk
Copy link
Contributor Author

@peterromfeldhk peterromfeldhk commented Feb 12, 2019

also seems to work fine on nixos

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale label Jun 1, 2020
@wmertens
Copy link
Contributor

@wmertens wmertens commented Jun 6, 2020

Well this seems ok - too bad it uses a binary install while the source is at https://www.github.com/SonarSource/sonar-scanner-cli

I'm a bit conflicted, on the one hand it's Java so compiling ourselves won't make much of a difference, OTOH we try to be a from-source distro.

@peterromfeldhk what do you think? If you prefer maintaining the binary version I'll just merge it.

@stale stale bot removed the 2.status: stale label Jun 6, 2020
@puffnfresh
Copy link
Contributor

@puffnfresh puffnfresh commented Sep 21, 2020

@wmertens I'd like to see this merged. I agree it would be better to do from-source but I don't want that to block having this be readily available for NixOS users. I agree it won't make much of a difference since it's Java.

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 23, 2020

Result of nixpkgs-review pr 55558 1

1 package built:
- sonar-scanner-bin

@ryantm ryantm merged commit e3ac67d into NixOS:master Oct 23, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants