Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-chess: 3.30.0 -> 3.30.1 #55608

Merged
merged 1 commit into from Feb 17, 2019
Merged

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 12, 2019

Motivation for this change

After fixing common-update-scripts
found this could be updated.
(and related gnome-y updates submitted as sibling PR's)
No other reason O:).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Builds and executes fine, news looks minimal.

However I don't think we have a game engine configured for this.
So the default function isn't complete.

Looks like the default engine fedora uses is gnuchess so maybe we should add an option to include it in path?

@worldofpeace worldofpeace merged commit e6b76ad into NixOS:master Feb 17, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants