New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdimgtools,libdvdcss12,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 #55615

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hhm0
Copy link
Contributor

hhm0 commented Feb 12, 2019

Motivation for this change

Adds the CD|imgtools package, which is useful for certain operations on CD images.

Also adds its dependencies which were not already present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hhm0 hhm0 changed the title cdimgtools: init at 0.3, libdvdcss12: init at 1.2.13, perlPackages.DataHexdumper: init at 3.001 cdimgtools,libdvdcss12,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 Feb 12, 2019

@hhm0

This comment has been minimized.

Copy link
Contributor Author

hhm0 commented Feb 12, 2019

@@ -10777,6 +10781,10 @@ in
inherit (darwin) IOKit;
};

libdvdcss12 = callPackage ../development/libraries/libdvdcss/1.2.nix {

This comment has been minimized.

@grahamc

grahamc Feb 15, 2019

Member

I'm not real keen on adding a second version of libdvdcss, and one which is no longer maintained at that. It would be much better to find a way to make cd imgools work with the current, maintained, version

This comment has been minimized.

@hhm0

hhm0 Feb 15, 2019

Author Contributor

Got it, thanks for the review! Hope to see what patching cdimgtools to use latest libdvdcss involves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment