Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdimgtools,perlPackages.DataHexdumper: init at 0.3, init at 3.001 #55615

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
4 participants
@hhm0
Copy link
Contributor

commented Feb 12, 2019

Motivation for this change

Adds the CD|imgtools package, which is useful for certain operations on CD images.

Also adds its dependencies which were not already present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hhm0 hhm0 changed the title cdimgtools: init at 0.3, libdvdcss12: init at 1.2.13, perlPackages.DataHexdumper: init at 3.001 cdimgtools,libdvdcss12,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 Feb 12, 2019

@hhm0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

@hhm0 hhm0 changed the title cdimgtools,libdvdcss12,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 cdimgtools,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 Feb 21, 2019

@hhm0 hhm0 changed the title cdimgtools,perlPackages.DataHexdumper: init at 0.3, init at 1.2.13, init at 3.001 cdimgtools,perlPackages.DataHexdumper: init at 0.3, init at 3.001 Feb 21, 2019

@hhm0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Is this ready to be merged? It is now compatible with latest libdvdcss.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Also please rebase instead of merging, and squash/fixup any extra commits or cleanup the git history.

@hhm0 hhm0 force-pushed the hhm0:cdimgtools branch from 6ea7e3b to 2d17bfb Feb 27, 2019

@hhm0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@worldofpeace Integrated your suggestions and squashed the commits. Thanks for the review!

@hhm0 hhm0 force-pushed the hhm0:cdimgtools branch from 2d17bfb to fdca55e Feb 27, 2019

@worldofpeace
Copy link
Member

left a comment

Looks good, though I haven't tested this, so I need to verify its function through other means.

@hhm0 Have you tested that all the binaries produced worked for you?

@hhm0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@hhm0 Have you tested that all the binaries produced worked for you?

@worldofpeace Yup

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@hhm0 Have you tested that all the binaries produced worked for you?

@worldofpeace Yup

Great, merging in that case 👍

@worldofpeace worldofpeace merged commit 5fe4729 into NixOS:master Feb 27, 2019

1 check was pending

grahamcofborg-eval Checking original out paths
Details
@hhm0

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@worldofpeace Thanks for your help reviewing and suggesting! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.