Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapian: 1.4.9 -> 1.4.10 #55624

Merged
merged 1 commit into from Feb 15, 2019
Merged

xapian: 1.4.9 -> 1.4.10 #55624

merged 1 commit into from Feb 15, 2019

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 12, 2019

https://xapian.org/docs/xapian-core-1.4.10/NEWS

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

@dtzWill dtzWill commented Feb 15, 2019

LGTM ('notmuch' usage).

@dtzWill dtzWill merged commit 5bd0cdb into NixOS:master Feb 15, 2019
13 checks passed
@dtzWill dtzWill deleted the update/xapian-1.4.10 branch Feb 15, 2019
@jb55
Copy link
Contributor

@jb55 jb55 commented Feb 24, 2019

@dtzWill I think this broke notmuch's date: search for me, can you confirm?

notmuch count date:year..

always gives me zero.

@jb55
Copy link
Contributor

@jb55 jb55 commented Feb 24, 2019

actually this might be a notmuch issue... reverting this change had no effect..

@jb55
Copy link
Contributor

@jb55 jb55 commented Feb 24, 2019

nevermind, looks like this does indeed break notmuch date queries.

@jb55
Copy link
Contributor

@jb55 jb55 commented Feb 24, 2019

after chatting with the xapian people this might just be an issue with my database for some reason. @dtzWill let me know if this still works for you and then you can disregard this.

@dtzWill
Copy link
Member Author

@dtzWill dtzWill commented Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants