Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/qemu-vm: declarative drives #55645

Merged
merged 1 commit into from Nov 4, 2019
Merged

Conversation

@eonpatapon
Copy link
Contributor

@eonpatapon eonpatapon commented Feb 12, 2019

Adds virtualisation.qemu.drives option to specify drives to be used by
qemu.

Also fix boot when virtualisation.useBootLoader is set to true. Since
the boot disk is second qemu doesn't boot on it. Added bootindex=1 to
the boot disk device.

Motivation for this change

Wanted to use useBootLoader at first but it's broken. Tried to fix it but it was messy hence I decided to rewrite a bit the drives handling code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adds `virtualisation.qemu.drives` option to specify drives to be used by
qemu.

Also fix boot when `virtualisation.useBootLoader` is set to true. Since
the boot disk is second qemu doesn't boot on it. Added `bootindex=1` to
the boot disk device.
@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Feb 20, 2019

@GrahamcOfBorg test upnp virtualbox installer

@ElvishJerricco
Copy link
Contributor

@ElvishJerricco ElvishJerricco commented Feb 25, 2019

This fixed useBootLoader for me (which consequently also fixed plymouth not working in qemu; for some reason you need grub for that)

@wmertens
Copy link
Contributor

@wmertens wmertens commented Nov 4, 2019

@GrahamcOfBorg test upnp virtualbox installer

Copy link
Contributor

@wmertens wmertens left a comment

LGTM. Can't think of a reason not to merge this.

@wmertens wmertens merged commit 59e731b into NixOS:master Nov 4, 2019
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants