Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godef: 1.0.0 -> 1.1.1 #55651

Merged
merged 2 commits into from Feb 19, 2019
Merged

godef: 1.0.0 -> 1.1.1 #55651

merged 2 commits into from Feb 19, 2019

Conversation

@rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Feb 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@rvolosatovs rvolosatovs commented Feb 19, 2019

@worldofpeace worldofpeace merged commit 82cde8f into NixOS:master Feb 19, 2019
12 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 19, 2019

Thank you @rvolosatovs 👍

@rvolosatovs rvolosatovs deleted the update/godef branch Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants