Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups-brother-hl3140cw: init at 1.1.4-0 #55664

Merged
merged 1 commit into from Feb 26, 2019
Merged

cups-brother-hl3140cw: init at 1.1.4-0 #55664

merged 1 commit into from Feb 26, 2019

Conversation

@NickHu
Copy link
Contributor

@NickHu NickHu commented Feb 12, 2019

Motivation for this change

Adds the Brother HL-3140CW CUPS printer driver. When setting up the printer in the CUPS interface, the PPD needs to be added manually (from the nix store) - perhaps this could be changed, but I'm not familiar enough with CUPS to understand how it works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Infinisil Infinisil left a comment

I know you got this expression from other driver definitions, but please don't just blindly copy it over next time. (the driver definitions really could use an overhaul..).

pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Show resolved Hide resolved
pkgs/misc/cups/drivers/hl3140cw/default.nix Outdated Show resolved Hide resolved
@NickHu
Copy link
Contributor Author

@NickHu NickHu commented Feb 26, 2019

@Infinisil I think I addressed all of your concerns, did I miss anything?

Copy link
Member

@Infinisil Infinisil left a comment

Thanks!

@Infinisil Infinisil merged commit 661e3ba into NixOS:master Feb 26, 2019
10 checks passed
@NickHu NickHu deleted the hl3140cw branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants