Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoneminder: fix build issue when using createLocally database #55667

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@amazari
Copy link
Contributor

@amazari amazari commented Feb 12, 2019

Motivation for this change

In its current state, a configuration.nix enabling the zoneminder service and setting its 'database.createLocally" flag cannot be build.
It is caused by providing wrongly typed arguments to the ensureUsers and ensurePermissions built-ins.

Things done

Fix the types:

  • list for ensureUsers
  • set for ensurePermissions

Note that the createLocally logic is still broken for user permission reason. I'll look into it in a following PR.

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Feb 14, 2019

Ping @peterhoeg

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Feb 15, 2019

That's super strange - my testing of this must have been bad. I do admittedly not run with this option enabled myself.

There is definitely room for improvement in the ZM support, so please keep the PRs coming.

@peterhoeg peterhoeg merged commit 507855e into NixOS:master Feb 15, 2019
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants