Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp: fix darwin sandbox build and cleanup #55671

Merged
merged 1 commit into from Feb 13, 2019

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 12, 2019

The tests use localhost networking, which is disallowed by
default in the darwin sandbox.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The tests use localhost networking, which is disallowed by
default in the darwin sandbox.
@GrahamcOfBorg GrahamcOfBorg requested a review from edolstra Feb 12, 2019
@LnL7 LnL7 merged commit aee2dc8 into NixOS:master Feb 13, 2019
13 checks passed
@LnL7 LnL7 deleted the darwin-aws-sdk-cpp branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants