Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: fix crash #55673

Merged
merged 1 commit into from Feb 13, 2019
Merged

nextcloud-client: fix crash #55673

merged 1 commit into from Feb 13, 2019

Conversation

@averelld
Copy link
Contributor

@averelld averelld commented Feb 12, 2019

Motivation for this change

Fixes #55639

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

@flokli flokli commented Feb 13, 2019

@GrahamcOfBorg build nextcloud-client

@Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 13, 2019

built and tested locally 👍

@flokli flokli merged commit 3627e56 into NixOS:master Feb 13, 2019
13 checks passed
@flokli
Copy link
Contributor

@flokli flokli commented Feb 13, 2019

@Ma27 can you backport to 18.09?

@Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 13, 2019

Ok, you were slightly faster than me 😅

As release-18.09 also uses 2.5.1 I guess it's affected as well and I'll backport :)

@Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 13, 2019

(backport will be delayed, I'm currently building a lot of stuff on release-18.09 and it'll take some more time...)

@averelld averelld deleted the fix-nextcloud-crash branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants