Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.aplpy: init at 2.0.3 #55711

Merged
merged 6 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@smaret
Copy link
Contributor

smaret commented Feb 13, 2019

Motivation for this change

Add a Nix expression for the Aplpy Python package and its dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret smaret requested a review from FRidh as a code owner Feb 13, 2019

@smaret smaret changed the title Aplpy: init at 2.0.rc2 aplpy: init at 2.0.rc2 Feb 13, 2019

@dotlambda dotlambda changed the title aplpy: init at 2.0.rc2 pythonPackages.aplpy: init at 2.0.rc2 Feb 13, 2019

@dotlambda
Copy link
Member

dotlambda left a comment

Please correct the commit messages and fix the evaluation errors.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 13, 2019

@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 13, 2019

Download error on https://pypi.python.org/simple/astropy-helpers/: [Errno -2] Name or service not known -- Some packages may not be found!

@smaret smaret force-pushed the smaret:aplpy branch from 49ece42 to 241de9f Feb 13, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Feb 13, 2019

Download error on https://pypi.python.org/simple/astropy-helpers/: [Errno -2] Name or service not known -- Some packages may not be found!

Where does this come from?

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 13, 2019

You will find it in the build log (see the checks):
@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy
It's probably a result of building in the sandbox

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

Please reorder the commits and squash the last 3 ones into your earlier ones.

@smaret smaret force-pushed the smaret:aplpy branch from f065386 to aa76f07 Feb 14, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Feb 14, 2019

@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 14, 2019

I still get the same error locally.

@smaret smaret force-pushed the smaret:aplpy branch from aa76f07 to a6ba5bc Feb 25, 2019

@smaret smaret changed the title pythonPackages.aplpy: init at 2.0.rc2 pythonPackages.aplpy: init at 2.0.3 Feb 25, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Feb 27, 2019

I'm trying to reproduce this error on macOS with sandboxing, but I get a different error:

% nix-build -I. -A python3Packages.aplpy
these derivations will be built:
  /nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv
building '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv'...
unpacking sources
unpacking source archive /nix/store/kydlzzhjm9d9a838gqbnc50h7wdzk6fi-APLpy-2.0.3.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/yaxqbxpg4svc97ic2s01gqsd6d5209ar-gnutar-1.31/bin/tar
  Reason: no suitable image found.  Did find:
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/zchs18skjv75qg2iy0srwz1dvrrmfkv7-stdenv-darwin/setup: line 842: 83909 Abort trap: 6           tar xf "$fn"
do not know how to unpack source archive /nix/store/kydlzzhjm9d9a838gqbnc50h7wdzk6fi-APLpy-2.0.3.tar.gz
builder for '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv' failed with exit code 1
error: build of '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv' failed

Is this a bug in the gnutar package?

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 27, 2019

@smaret I have no experience whatsoever with Darwin. Maybe @matthewbauer can help out.

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 1, 2019

I've just on opened an issue for the gnutar sandbox issue on Darwin (#56591).

@smaret smaret force-pushed the smaret:aplpy branch from a6ba5bc to 7ad414f Mar 3, 2019

@smaret smaret force-pushed the smaret:aplpy branch from 7ad414f to 30795b0 Mar 11, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 11, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@smaret smaret force-pushed the smaret:aplpy branch from 30795b0 to 41aee9e Mar 11, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 11, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 11, 2019

I finally managed to get the sandbox working on Darwin 🎉

The download error was caused by an automatic update of the astropy-helpers module during the setup. I've patched the setup.cfg to fix it. The build log looks good now.

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 13, 2019

@dotlambda Can you please have a look at this when you get a chance? I think that the PR is now ready for merging.

smaret added some commits Feb 13, 2019

@smaret smaret force-pushed the smaret:aplpy branch from 41aee9e to a2ebd7a Mar 14, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Mar 14, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Mar 14, 2019

During the build of pyavm I get

Ran 0 tests in 0.000s

Please add an appropriate checkPhase or, if there are no tests, set doCheck = false and add a comment with the reason.

smaret added some commits Feb 25, 2019

@smaret smaret force-pushed the smaret:aplpy branch from a2ebd7a to 16fbffa Mar 15, 2019

@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 15, 2019

During the build of pyavm I get

Ran 0 tests in 0.000s

Please add an appropriate checkPhase

Done.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Mar 15, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda dotlambda merged commit d50fe70 into NixOS:master Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@smaret

This comment has been minimized.

Copy link
Contributor Author

smaret commented Mar 15, 2019

Thanks for your detailed review of this PR @dotlambda !

@smaret smaret deleted the smaret:aplpy branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.