Skip to content

python.pkgs.pytest-mock: 1.10.0 -> 1.10.1 #55716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2019
Merged

python.pkgs.pytest-mock: 1.10.0 -> 1.10.1 #55716

merged 2 commits into from
Feb 15, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 13, 2019 •
edited
Loading

Motivation for this change

The upgrade seems to have led to test failures at CherryPy's side. I'm not sure if the remaining ones are really related to network access or if that is in fact mocked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner February 13, 2019 17:10
@dotlambda dotlambda changed the base branch from master to python-unstable February 14, 2019 12:25
@dotlambda
Copy link
Member Author

@FRidh We should merge this into python-unstable because python3.pkgs.cherrypy probably won't build there even if the dependencies are fixed.

@GrahamcOfBorg GrahamcOfBorg added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Feb 14, 2019
@FRidh
Copy link
Member

FRidh commented Feb 15, 2019 •
edited
Loading

Yes, go ahead and cherry-pick / rebase the changes.

@FRidh FRidh merged commit a4628e6 into NixOS:python-unstable Feb 15, 2019
@FRidh
Copy link
Member

FRidh commented Feb 15, 2019

(Figured I might as well press the button immediately)

@dotlambda dotlambda deleted the pytest-mock-1.10.1 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @FRidh @GrahamcOfBorg