Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groff: Remove indeterminism in manpages #55729

Merged
merged 1 commit into from Feb 14, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Feb 13, 2019

It was caused by including the modification date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner
Copy link
Member Author

tilpner commented Feb 13, 2019

Used a patch instead of substituteInPlace for louder failure when the patch stops applying. Any better alternatives for next time?

@tilpner
Copy link
Member Author

tilpner commented Feb 13, 2019

@vcunat Okay, it uses the ChangeLog time now

It was caused by including the modification date
@lheckemann lheckemann merged commit 3cf2745 into NixOS:staging Feb 14, 2019
@vcunat
Copy link
Member

vcunat commented Feb 14, 2019

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants