Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.httpretty: fix darwin sandbox build #55781

merged 1 commit into from Feb 17, 2019


Copy link

@LnL7 LnL7 commented Feb 14, 2019

The tests use localhost networking and get stuck otherwise.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

The tests use localhost networking and get stuck otherwise.
@LnL7 LnL7 requested a review from FRidh as a code owner February 14, 2019 19:44
@LnL7 LnL7 merged commit a44784e into NixOS:master Feb 17, 2019
@LnL7 LnL7 deleted the darwin-httpretty branch February 17, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants