Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pantable: init at 0.12.2 #55797

Closed
wants to merge 4 commits into from
Closed

Conversation

@leenaars
Copy link
Contributor

leenaars commented Feb 15, 2019

Motivation for this change

Useful helper tool for working with pandoc tables + dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leenaars leenaars requested a review from FRidh as a code owner Feb 15, 2019
@leenaars leenaars force-pushed the leenaars:pantable branch 2 times, most recently from d63866c to e022a64 Feb 25, 2019
@leenaars leenaars force-pushed the leenaars:pantable branch from ee6943c to 2ebe617 Sep 10, 2019
@leenaars
Copy link
Contributor Author

leenaars commented Sep 10, 2019

Version meanwhile refreshed up to 12.2. AFAIK good to go.

@leenaars leenaars changed the title pythonPackages.pantable: init at 0.11.1 pythonPackages.pantable: init at 0.12.2 Sep 10, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
Copy link
Contributor

drewrisinger left a comment

Comments only on diff, didn't attempt to build it.

};

meta = with lib; {
homepage = https://github.com/mbr/shutilwhich;

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Quote URL

Suggested change
homepage = https://github.com/mbr/shutilwhich;
homepage = "https://github.com/mbr/shutilwhich";

meta = with lib; {
homepage = https://github.com/mbr/shutilwhich;
description = "shutil.which for legacy below Python 3.3";

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

with py27 deprecated, do we want to have new package for py<3.3?

pname = "panflute";
version = "1.11.2";

disabled = ! pythonAtLeast "3.5" && !isPy27;

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Confusing range, hard to read.

{ lib, buildPythonPackage, pythonAtLeast, isPy27, fetchPypi
, pyyaml, future, click, shutilwhich }:
Comment on lines +1 to +2

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Break onto multiple lines, alphabetize python packages.


meta = with lib; {
description = "Pythonic pandocfilters with extra helper functions";
homepage = http://scorreia.com/software/panflute/;

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Suggested change
homepage = http://scorreia.com/software/panflute/;
homepage = "http://scorreia.com/software/panflute/";
{ lib, buildPythonPackage, pythonAtLeast, isPy27, fetchPypi
, panflute, backports_csv }:
Comment on lines +1 to +2

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Same as above, line per package

pname = "pantable";
version = "0.12.2";

disabled = ! pythonAtLeast "3.5" && !isPy27;

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

ditto on confusing


meta = with lib; {
description = "CSV Tables in Markdown: Pandoc Filter for CSV Tables";
homepage = https://ickc.github.io/pantable/;

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

Suggested change
homepage = https://ickc.github.io/pantable/;
homepage = "https://ickc.github.io/pantable/";
@@ -4691,7 +4693,7 @@ in
'';
});

pamtester = callPackage ../tools/security/pamtester { };
pantable = python3Packages.callPackage ../tools/text/pantable { };

This comment has been minimized.

@drewrisinger

drewrisinger Mar 27, 2020 Contributor

python packages should usually be in pkgs/top-level/python-packages.nix. Not sure why this package should be at top-level.

@leenaars leenaars closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.