Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/geoip-updater: remove #55867

Closed
wants to merge 1 commit into from
Closed

Conversation

@volth
Copy link
Contributor

volth commented Feb 16, 2019

Motivation for this change

2019-01-01 MaxMind stopped distributing GeoIP v1 databases.
This service does not work since then and its presence in NixOS creates false confidence that the GeoIP databases are still being updated.
But they are not.

Fixing seems a bad option, because a fixed service would provide only GeoIP v2 and thus won't be a replacement for what the service was before and it would require all numerous services which use GeoIP database to update to newer MaxMind library (which is not backward compatible)

So, it would be better if the next service have a different name, for example nixos/geoip-v2-updater.
And broken nixos/geoip-updater is to be gone to avoid confusions.

Related: #53953

2019-01-01 MaxMind stopped distributing GeoIP v1 databases.
This service does not work since then and its presense in NixOS creates false confidence that the GeoIP databases are still being updated.
But they are not.

Related: #53953
@volth volth requested a review from Infinisil as a code owner Feb 16, 2019
@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented Feb 24, 2019

Needs at least a mkRemovedOption for the removed options.

danbst added a commit to danbst/nur-packages that referenced this pull request Mar 5, 2019
Upstream doesn't care about stableness and reproducibility
but this module can still be used as part of another, more declarative process
@danbst

This comment has been minimized.

Copy link
Contributor

danbst commented Mar 5, 2019

I've moved this module to my personal NUR

danbst/nur-packages@5b5a99b

In general, I agree that this breaks reproducibility in a hard way. And the part where database file is removed generates even more pain.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Jul 12, 2019

@volth care to add mkRemovedOption so we can merge?

@dasJ

This comment has been minimized.

Copy link
Member

dasJ commented Nov 17, 2019

Could be replacable with: https://dev.maxmind.com/geoip/geoipupdate/

@dasJ dasJ mentioned this pull request Nov 17, 2019
4 of 10 tasks complete
@dasJ dasJ mentioned this pull request Dec 23, 2019
3 of 10 tasks complete
@mmilata

This comment has been minimized.

Copy link
Contributor

mmilata commented Dec 23, 2019

FYI even the GeoIPv2 databases will be unavailable starting 2020-01-01: https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/ You'll be able to get them for free but registration will be needed.

@dasJ

This comment has been minimized.

Copy link
Member

dasJ commented Dec 23, 2019

@mmilata Do you know if we're still able to get them with #73767?

@mmilata

This comment has been minimized.

Copy link
Contributor

mmilata commented Dec 24, 2019

@dasJ I think so, though the 0 accountID may stop working I guess?

@volth volth closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.