Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_testing_bcachefs: 4.20.2019.02.09 -> 4.20.2019.02.20 #55928

merged 1 commit into from Feb 28, 2019


Copy link

@hyperfekt hyperfekt commented Feb 17, 2019

Motivation for this change

This fixes koverstreet/bcachefs#16.

Things done

The test is broken on unstable and master, but I'm running this kernel right now without problems, as opposed to the old one.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

@eadwu eadwu commented Feb 17, 2019

Works fine for me (manual patch), albeit the expected errors of upgrading a filesystem without reformatting.

Copy link
Contributor Author

@hyperfekt hyperfekt commented Feb 18, 2019

I didn't realize it wasn't backwards compatible, maybe it's time to introduce allow pinning a bcachefs version while disk format upgrades are still happening.

@hyperfekt hyperfekt force-pushed the hyperfekt:bcachefs-update branch from d49057b to 91c252b Feb 26, 2019
@hyperfekt hyperfekt changed the title linux_testing_bcachefs: 4.20.2019.02.09 -> 4.20.2019.02.15 linux_testing_bcachefs: 4.20.2019.02.09 -> 4.20.2019.02.20 Feb 27, 2019
@dywedir dywedir merged commit bae8807 into NixOS:master Feb 28, 2019
10 checks passed
10 checks passed
grahamcofborg-eval ^.^!
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
grahamcofborg-eval-check-meta config.nix: checkMeta = true
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
grahamcofborg-eval-package-list nix-env -qa --json --file .
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.