Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sickbeard: fix build #55941

Merged
merged 1 commit into from Feb 17, 2019
Merged

sickbeard: fix build #55941

merged 1 commit into from Feb 17, 2019

Conversation

rembo10
Copy link
Contributor

@rembo10 rembo10 commented Feb 17, 2019

Motivation for this change

See e0e7e86
Same fix needed for sickbeard

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Use the `pythonEnv` provided by `buildInputs` rather than the one
provided by `buildPythonApplication`.
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

@GrahamcOfBorg build sickbeard

@ryantm ryantm merged commit 85765ac into NixOS:master Feb 17, 2019
@ryantm
Copy link
Member

ryantm commented Feb 17, 2019

thanks; please consider adding yourself as a maintainer.

@rembo10 rembo10 deleted the sickbeard branch February 18, 2019 01:15
@rembo10
Copy link
Contributor Author

rembo10 commented Feb 18, 2019

Sure, I actually add myself as a maintainer in #46514. Would it be too much trouble to merge that in? There was a conflict with the ids which is I guess why it sat so long but I just took care of it. Then I can add myself as a maintainer on these

@ryantm
Copy link
Member

ryantm commented Feb 18, 2019

@rembo10 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants