Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for diod #55955

merged 2 commits into from Feb 17, 2019

Fixes for diod #55955

merged 2 commits into from Feb 17, 2019


Copy link

@rnhmjoj rnhmjoj commented Feb 17, 2019

Motivation for this change

Wanted to create a NAS with a 9P filesystem.
This also fixes part of #53716.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

I'm not sure why the capabilities has been restricted to cap_net_bind_service. The daemon needs to run as root and require almost every capability: at least cap_net_bind_service, cap_setgid, cap_chown and more that I couldn't figure out by trial and error.

cc @rickynils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants