Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome_5: 5.6.3 -> 5.7.2 #55967

Merged
merged 2 commits into from Feb 26, 2019
Merged

font-awesome_5: 5.6.3 -> 5.7.2 #55967

merged 2 commits into from Feb 26, 2019

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 added 2 commits Feb 17, 2019
It is confusing that font-awesome_4 is the font,
one get when installing font-awesome-ttf.
I don't really see a use case to keep the old version around.
@Mic92 Mic92 merged commit 699d313 into NixOS:master Feb 26, 2019
13 checks passed
@Mic92 Mic92 deleted the font-awesome branch Feb 26, 2019
@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Jul 12, 2019

I don't think we should remove font-awesome v4.
They don't support the same glyphs/characters and programs need to be actively converted.
This causes issues, e.g. greshake/i3status-rust#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants