Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoneminder: Fix locally created database #56015

Closed
wants to merge 0 commits into from
Closed

Conversation

amazari
Copy link
Contributor

@amazari amazari commented Feb 18, 2019

Motivation for this change

In its current form the database.createLocally flag is broken. Those patches try to fix it.

Things done

After fixing types in a previous one, the two here fix:

  • mysql user auth: ensure that the mysql and the unix user running zonminder share the same name in order to allow unix socket mysql connection as enforced by the 'ensureUsers' directive
  • move the initial db creation and population to the right scope

Only tested locally after recreating /etc/mysql_init file.

Ping @peterhoeg

@amazari amazari requested a review from infinisil as a code owner February 18, 2019 20:13
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 18, 2019
@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 19, 2019
@amazari
Copy link
Contributor Author

amazari commented Feb 22, 2019

Hey @peterhoeg,

Could you have a look at the patches? I am concerned the mysql username impacts the non-locally created use case.
Thanks!

@alyssais
Copy link
Member

alyssais commented Mar 4, 2019

1,953 commits

You might want to rebase this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants