Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openafs_1_8: Include support for Linux 4.20 #56080

Merged
merged 1 commit into from Feb 26, 2019

Conversation

@artemist
Copy link
Member

@artemist artemist commented Feb 20, 2019

Motivation for this change

OpenAFS version 1.8.2 does not have support for Linux 4.20,
meaning that linuxPackages_latest.openafs_1_8 would fail
to build.

Things done

This patch adds patches taken from the OpenAFS git (via the Arch AUR) to
remove the references to deprecated functions. This has been
tested on Linux 4.20 and Linux 4.14

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

OpenAFS version 1.8.2 does not have support for Linux 4.20,
meaning that linuxPackages_latest.openafs_1_8 would fail
to build.

This patch adds patches taken from the OpenAFS git to
remove the references to deprecated functions. This has been
tested on Linux 4.20 and Linux 4.14

This patch must be removed when OpenAFS 1.8.3 is released
and improved when Linux 5.0 is added to Nix
Copy link
Contributor

@maggesi maggesi left a comment

LGTM
(Compiles on my computer, can not test on production though.)

@artemist
Copy link
Member Author

@artemist artemist commented Feb 20, 2019

I haven't tested the server (I don't have a machine setup for that, and don't feel like making a new Kerberos realm), but I'm successfully logged into several cells and able to interact with files

@artemist
Copy link
Member Author

@artemist artemist commented Feb 26, 2019

Should I change base to staging or is master fine for <100 rebuilds?

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 26, 2019

@artemist master is fine

veprbl
veprbl approved these changes Feb 26, 2019
Copy link
Member

@veprbl veprbl left a comment

Client works

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 26, 2019

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 26, 2019

So this only provides a fix for 1.8. The default is 1.6 and it will probably need fixing or the default will need to be bumped.

@veprbl veprbl merged commit 1a95a36 into NixOS:master Feb 26, 2019
10 checks passed
@veprbl
Copy link
Member

@veprbl veprbl commented Feb 26, 2019

@artemist Thank you!

@spacefrogg
Copy link
Contributor

@spacefrogg spacefrogg commented Feb 27, 2019

@artemist Would you consider patching version 1.6 also? Or provide me with guidance on how to acquire the patch for the 1.6 branch?

Testing the server is not necessary. The kernel module solely affects the client.

@artemist
Copy link
Member Author

@artemist artemist commented Feb 27, 2019

@spacefrogg I've never used OpenAFS 1.6. There are some patches on the git server, but those are for 1.8, and I don't know how well they'll apply to 1.6. You can just try to apply these patches though.

@artemist artemist deleted the openafs-linux_latest branch Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants