Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktouch: fix build failure due to dependecy missing #56103

Merged
merged 1 commit into from Feb 22, 2019
Merged

Conversation

@schmittlauch
Copy link
Contributor

schmittlauch commented Feb 20, 2019

fixes #56097

Motivation for this change

ktouch failed to build on unstable due to a missing dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch schmittlauch requested a review from ttuegel as a code owner Feb 20, 2019
@schmittlauch

This comment has been minimized.

Copy link
Contributor Author

schmittlauch commented Feb 20, 2019

@vcunat When I first packaged ktouch I did that for unstable, and back then it actually did build. But whatever, this here should fix it.

@schmittlauch

This comment has been minimized.

Copy link
Contributor Author

schmittlauch commented Feb 20, 2019

@GrahamcOfBorg build ktouch

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Feb 21, 2019

I can confirm it now builds on both our linux platforms. I suppose there was some significant change on master between the PR being filed and merged.

Does it run for you? For me it exits with

can't find resource: "schemata/data.xsd"

but I do know some KDE won't run for me due to not having Plasma installed system-wide. In any case, this PR seems a strict improvement.

@schmittlauch

This comment has been minimized.

Copy link
Contributor Author

schmittlauch commented Feb 21, 2019

Does it run for you? For me it exits with

can't find resource: "schemata/data.xsd"

KTouch is one of the Qt applications heavily suffering from environment impurities. It needs to be installed into your user/ system environment, e.g. using nix-env. nix-shell alone does not suffice.
I verified that this KTouch build runs correctly when installed using nix-env

@vcunat
vcunat approved these changes Feb 22, 2019
Copy link
Member

vcunat left a comment

Tested via nix-env -i.

Nitpick: I can't find out how to change lessons to a different layout/language, but I had trained with ktouch in some 4.x version IIRC so perhaps I'm just missing something obvious...

@vcunat vcunat merged commit f9dab19 into NixOS:master Feb 22, 2019
10 checks passed
10 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vcunat added a commit that referenced this pull request Feb 22, 2019
@schmittlauch schmittlauch deleted the schmittlauch:ktouch branch Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.