Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protonmail-bridge: 1.1.0-1 -> 1.1.1-1 #56149

Merged
merged 1 commit into from Feb 28, 2019
Merged

Conversation

@GRBurst
Copy link
Contributor

@GRBurst GRBurst commented Feb 21, 2019

Motivation for this change
  • Update to newest version
  • previous version segfaulted since it was not pinned to qt 5.11. no it runs again
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GRBurst GRBurst changed the title Protonmail bridge protonmail-bridge 1.1.0-1 -> 1.1.1-1 Feb 21, 2019
@GRBurst
Copy link
Contributor Author

@GRBurst GRBurst commented Feb 21, 2019

just found that there is also a related issue. fixes #54457

- fix segmentation fault by explicitly calling qt 5.11
@GRBurst GRBurst force-pushed the GRBurst:protonmail-bridge branch from 6d14b07 to cb82146 Feb 21, 2019
@GRBurst
Copy link
Contributor Author

@GRBurst GRBurst commented Feb 21, 2019

sry forgot to rebase to upstream - there are no conflicts now

@GRBurst GRBurst changed the title protonmail-bridge 1.1.0-1 -> 1.1.1-1 protonmail-bridge: 1.1.0-1 -> 1.1.1-1 Feb 24, 2019
@aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Feb 28, 2019

I'm getting an error while trying to build this on both NixOS 18.09 and 19.03:

error: Package ‘4store-1.1.6’ in /nix/store/wf5dr000ld3s35fvadrb0fjj8kq2ra7b-unixos-19.09pre170705.1233c8d9e9b/unixos/pkgs/servers/http/4store/default.nix:44 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use '--show-trace' to show detailed location information)

I tried to set allowBroken to true, which led to me needing to accept an Android Studio license agreement, which led to an unsupported platform (which I didn't try to bypass since I assumed I was already pretty far down the rabbit hole).

EDIT: I am relatively new to contributing to NixOS so this might be a problem on my side, but I've built other yet-to-be-merged packages in the past without problem, especially without encountering broken packages.

@GRBurst
Copy link
Contributor Author

@GRBurst GRBurst commented Feb 28, 2019

@aaronduino what are the particular steps that led to this error? did you install it within a custom buildEnv or separately?
I guess your deduction with the Android Studio is right, this is unrelated to this package.

@aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Feb 28, 2019

nix-env -iI protonmail-bridge.nix

Maybe I'm installing it incorrectly, but I'm pretty sure this shouldn't result in anything involving Android Studio.

I'm running NixOS 19.03 (19.03 branch, pulled two days ago). I tried this on NixOS 18.09 with the same result.

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

@GrahamcOfBorg build protonmail-bridge

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

Well, build succeeds on ofborg and my local machine, and I cannot see anything related to 4store, so I'll merge this now. @aaronduino your issue does look unrelated.

@xeji xeji merged commit 071ee21 into NixOS:master Feb 28, 2019
13 checks passed
13 checks passed
protonmail-bridge on aarch64-linux No attempt
Details
protonmail-bridge on x86_64-darwin No attempt
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protonmail-bridge on x86_64-linux Success
Details
@aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Feb 28, 2019

Okay, makes sense.

Thanks for merging without me; I didn't want to hold anything up for an unrelated reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.