Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.mlgmpidl: 1.2.7 -> 1.2.8 #56154

Merged
merged 1 commit into from Feb 28, 2019
Merged

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 21, 2019

This version builds even if profiling is not available (e.g., on Aarch).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Feb 21, 2019

@GrahamcOfBorg build framac glsurf

Loading

@vbgl vbgl force-pushed the ocaml-mlgmpidl-1.2.8 branch from 1b17a83 to bc5f835 Feb 21, 2019
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Feb 21, 2019

@GrahamcOfBorg build framac glsurf

Loading

1 similar comment
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Feb 21, 2019

@GrahamcOfBorg build framac glsurf

Loading

@vbgl vbgl force-pushed the ocaml-mlgmpidl-1.2.8 branch from f65d919 to 43428f2 Feb 21, 2019
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Feb 21, 2019

@GrahamcOfBorg build framac glsurf

Loading

@vbgl vbgl force-pushed the ocaml-mlgmpidl-1.2.8 branch from 43428f2 to 96d9db2 Feb 22, 2019
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Feb 22, 2019

@GrahamcOfBorg build framac glsurf

Loading

This version builds even if profiling is not available (e.g., on Aarch).
@vbgl vbgl force-pushed the ocaml-mlgmpidl-1.2.8 branch from 96d9db2 to 57636b1 Feb 22, 2019
@vbgl vbgl changed the title [wip] ocamlPackages.mlgmpidl: 1.2.7 -> 1.2.8 ocamlPackages.mlgmpidl: 1.2.7 -> 1.2.8 Feb 22, 2019
@vbgl vbgl merged commit 79bc38c into NixOS:master Feb 28, 2019
10 checks passed
Loading
@vbgl vbgl deleted the ocaml-mlgmpidl-1.2.8 branch Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants