Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted gnome updates #56174

Merged
merged 6 commits into from Feb 22, 2019
Merged

assorted gnome updates #56174

merged 6 commits into from Feb 22, 2019

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Feb 22, 2019

Motivation for this change

See commit msg's for links to News

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Feb 22, 2019

We should probably add gdk-pixbuf to clutter-gst dependencies.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Feb 22, 2019

We should probably add gdk-pixbuf to clutter-gst dependencies.

Yep, since it's explicit now.

@worldofpeace worldofpeace force-pushed the worldofpeace:gnome-updates branch from 1d23caa to 194b0d1 Feb 22, 2019
@hedning

This comment has been minimized.

Copy link
Contributor

hedning commented Feb 22, 2019

Fixed the gnome-desktop bubblewrap patch.

@worldofpeace worldofpeace force-pushed the worldofpeace:gnome-updates branch from c61a230 to d14768d Feb 22, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Feb 22, 2019

Thanks @hedning

@worldofpeace worldofpeace merged commit 6a6e7f9 into NixOS:master Feb 22, 2019
@worldofpeace worldofpeace deleted the worldofpeace:gnome-updates branch Feb 22, 2019
@hedning

This comment has been minimized.

Copy link
Contributor

hedning commented Feb 25, 2019

So the thumbnailing script refuse to run due /var/cache/fontconfig not being present. A simple, but ad-hoc fix is telling gnome-desktop to use PKG_CONFIG_FONTCONFIG_CACHEDIR = "/etc/fonts";.

I guess a more robust fix is only mounting the fontconfig cache if it actually exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.