Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tahoe service #56175

Merged
merged 2 commits into from May 25, 2019
Merged

Tahoe service #56175

merged 2 commits into from May 25, 2019

Conversation

@MostAwesomeDude
Copy link
Contributor

MostAwesomeDude commented Feb 22, 2019

Motivation for this change

Fix #25273 and update the NixOS service for the Tahoe 1.13 CLI changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have not dogfooded these changes, in contrast to my usual Tahoe adventures. I would greatly appreciate independent confirmation that this works for folks.

Previously we used nothing, leading to #25273.

Big thanks to @t184256 for developing and testing this fix.

Fixes #25273.
Copy link
Member

Infinisil left a comment

Looks good to me. Since some time has passed, I'll wait for your OK before merging.

@rycee
rycee approved these changes May 25, 2019
Copy link
Member

rycee left a comment

I've been using these changes for a while now on 19.03 and they work well. As far as I can tell the module is useless without these changes so I would suggest a merge and a backport to 19.03.

@Infinisil Infinisil merged commit 0040ca9 into NixOS:master May 25, 2019
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented May 25, 2019

Backported in 41c8f21 (and parent)

@rycee

This comment has been minimized.

Copy link
Member

rycee commented May 25, 2019

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.