Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/top-level: expose current overlays in pkgs #56237

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 23, 2019

This enables inspection of the currently used overlays. Useful for
usecases where nixpkgs is imported multiple times.
eg. different channels

self: super:
let
  latest = import <nixpkgs-trunk> {
    inherit (super) config overlays;
  };
in
{
  hello-custom-latest = latest.hello-custom;
}
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This enables inspection of the currently used overlays. Useful for
usecases where nixpkgs is imported multiple times.
eg. different channels

	self: super:
	let
	  latest = import <nixpkgs-trunk> {
	    inherit (super) config overlays;
	  };
	in
	{
	  hello-custom-latest = latest.hello-custom;
	}
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 23, 2019
@matthewbauer
Copy link
Member

This is probably okay, although it makes me a little concerned that packages will start inspecting the overlays - which they definitely should not be doing.

@LnL7
Copy link
Member Author

LnL7 commented Feb 24, 2019

While technically possible, there's not much you can do with them directly since it's a list of functions. What I was referring to with inspection is for debugging in the repl or builtins.trace.

nix-repl> :p pkgs.overlays
[ «lambda @ /path/to/example-overlay.nix:1:1» ]

@danbst danbst merged commit b421183 into NixOS:master Mar 5, 2019
@LnL7 LnL7 deleted the expose-overlays branch March 5, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants