Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-ignore: init at v0.2.0 #56248

Merged
merged 1 commit into from Feb 25, 2019
Merged

git-ignore: init at v0.2.0 #56248

merged 1 commit into from Feb 25, 2019

Conversation

@sondr3
Copy link
Contributor

sondr3 commented Feb 23, 2019

A small program to quickly and easily fetch .gitignore templates from
www.gitignore.io

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
A small program to quickly and easily fetch .gitignore templates from
www.gitignore.io
@sondr3 sondr3 force-pushed the sondr3:sondr3/git-ignore-init branch from 2e8f729 to 647668a Feb 25, 2019
@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 25, 2019

@GrahamcOfBorg build gitAndTools.git-ignore

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 25, 2019

Darwin failure is a weird ssh handshake issue:

error: failed to sync
Caused by:
  failed to load pkg lockfile
Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`
Caused by:
  [16/-1] unexpected return value from ssl handshake -9808

I've seen this with other rust packages recently, may be a transient issue or some github rate limit.

Anyway, @sondr3 if you can build it on a Mac I think we can ignore this.

@xeji xeji merged commit 4e0b4a2 into NixOS:master Feb 25, 2019
13 checks passed
13 checks passed
gitAndTools.git-ignore on x86_64-darwin Unexpected error: command failed with exit code 1
Details
gitAndTools.git-ignore on aarch64-linux Success
Details
gitAndTools.git-ignore on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@sondr3

This comment has been minimized.

Copy link
Contributor Author

sondr3 commented Feb 25, 2019

Yeah, it built fine on my Mac so it should be fine. Thanks!

@sondr3 sondr3 deleted the sondr3:sondr3/git-ignore-init branch Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.