Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost-desktop: 4.1.2 -> 4.2.0 #56289

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@jokogr
Copy link
Contributor

@jokogr jokogr commented Feb 24, 2019

Motivation for this change

Mattermost Desktop update was pending since November 2018.

New version seems to be using GTK 3 and has a Windows security vulnerability fixed (I guess no worries for that).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jokogr
Copy link
Contributor Author

@jokogr jokogr commented Feb 24, 2019

P.S.: I have also added my GPG key

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Hello @jokogr

Could you please drop

phases = [ "unpackPhase" "installPhase" ];

and replace it with?

dontBuild = true;
dontConfigure = true;

We'd like to deprecate that.
See: #28910

Additionally, after inspecting the output I noticed that everything was
just copied to $out with no type of hierarchy.

Could you refactor the installPhase to not do that?

This can be as simple as coping everything to $out/share/mattermost-desktop
and then symlinking things from there.

@jokogr
Copy link
Contributor Author

@jokogr jokogr commented Feb 25, 2019

@worldofpeace thanks for the review!

I've refactored the phases to use $out/share/mattermost-desktop, dropped lib and added myself as a maintainer. I excluded the patchPhase as well, since shrinking the rpath for the binary makes it not working (I get a SIGTRAP).

@jokogr jokogr force-pushed the u/mattermost-desktop-4.2.0 branch from 6f83cb1 to 2e9c741 Feb 26, 2019
@jokogr
Copy link
Contributor Author

@jokogr jokogr commented Feb 26, 2019

@worldofpeace ready!

@worldofpeace worldofpeace merged commit 28cb3f4 into NixOS:master Feb 26, 2019
7 of 9 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 26, 2019

Thanks @jokogr 😄

@jokogr jokogr deleted the u/mattermost-desktop-4.2.0 branch Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants