Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes several broken python packages for python-unstable #56312

Merged
merged 7 commits into from Feb 25, 2019

Conversation

@costrouc
Copy link
Contributor

costrouc commented Feb 24, 2019

Motivation for this change

#55757

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 24, 2019

"depreciated" -> "deprecated"

@dotlambda dotlambda removed the request for review from ryantm Feb 24, 2019
@costrouc costrouc force-pushed the costrouc:python-unstable branch 2 times, most recently from 36e5227 to be06dd7 Feb 24, 2019
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 25, 2019

Two further things that should be changed in your commit messages:

  • "depreciated" -> "deprecated"
  • pythonPackages.monty: 1.0.2 -> 1.0.4
@dotlambda dotlambda force-pushed the costrouc:python-unstable branch from be06dd7 to 8c0516e Feb 25, 2019
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 25, 2019

I did the changes myself. Please have a look at the changes I made to shapely.

@costrouc

This comment has been minimized.

Copy link
Contributor Author

costrouc commented Feb 25, 2019

@dotlambda looks good to me! Sorry didn't have time this morning to make the edits

@dotlambda dotlambda merged commit 0dbfd0e into NixOS:staging-next Feb 25, 2019
10 checks passed
10 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 25, 2019

Sorry didn't have time this morning to make the edits

No problem. Thank you very much for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.