Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candle: init at 1.1 #56328

Merged
merged 2 commits into from Mar 11, 2019
Merged

candle: init at 1.1 #56328

merged 2 commits into from Mar 11, 2019

Conversation

@matti-kariluoma
Copy link

matti-kariluoma commented Feb 25, 2019

Motivation for this change

I've added an application for controlling GRBL machines, its source can be found at https://github.com/Denvi/Candle

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS v18.09
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/candle/default.nix Outdated Show resolved Hide resolved
@peterhoeg

This comment has been minimized.

Copy link
Member

peterhoeg commented Feb 25, 2019

@matti-kariluoma, I just realized that this is your first PR here, so I'd like to say thank you for this!

If you need anything clarified, feel free to ask.

@matti-kariluoma

This comment has been minimized.

Copy link
Author

matti-kariluoma commented Mar 2, 2019

I removed candle from my system, made the requested changes then reinstalled. All working!

@peterhoeg

This comment has been minimized.

Copy link
Member

peterhoeg commented Mar 4, 2019

Looks good - as the last thing, can I get you to squash the commits so we end up with one commit adding you to the maintainer list and another that has all the changes for the actual software?

@matti-kariluoma matti-kariluoma force-pushed the matti-kariluoma:master branch from 686aa22 to 83a3e29 Mar 5, 2019
@matti-kariluoma

This comment has been minimized.

Copy link
Author

matti-kariluoma commented Mar 5, 2019

Looks like I can't resolve the last change request, probably due to the rebase... Do I need to create a new pull request?

Matti Kariluoma
@matti-kariluoma matti-kariluoma force-pushed the matti-kariluoma:master branch from 83a3e29 to 7b5318f Mar 9, 2019
@matti-kariluoma

This comment has been minimized.

Copy link
Author

matti-kariluoma commented Mar 9, 2019

Alright, that should be all of the requsted changes. Squashed down to two commits as well

@peterhoeg peterhoeg merged commit f4ffe5c into NixOS:master Mar 11, 2019
10 checks passed
10 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@peterhoeg

This comment has been minimized.

Copy link
Member

peterhoeg commented Mar 11, 2019

Looks great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.