-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
candle: init at 1.1 #56328
candle: init at 1.1 #56328
Conversation
@matti-kariluoma, I just realized that this is your first PR here, so I'd like to say thank you for this! If you need anything clarified, feel free to ask. |
I removed candle from my system, made the requested changes then reinstalled. All working! |
Looks good - as the last thing, can I get you to squash the commits so we end up with one commit adding you to the maintainer list and another that has all the changes for the actual software? |
Looks like I can't resolve the last change request, probably due to the rebase... Do I need to create a new pull request? |
Alright, that should be all of the requsted changes. Squashed down to two commits as well |
Looks great! Thank you. |
Motivation for this change
I've added an application for controlling GRBL machines, its source can be found at https://github.com/Denvi/Candle
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)