Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexibee accounting system, initial commit #56336

Closed
wants to merge 4 commits into from
Closed

Conversation

@petrkr
Copy link

petrkr commented Feb 25, 2019

Motivation for this change

Have accounting system which we use at our company

Things done

This initial commit support only client of this accounting system. TAR Package itself contains also server side, but we do not need it at this time, so package is not done. It can be done if someone needs it later anyway.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@petrkr

This comment has been minimized.

Copy link
Author

petrkr commented Mar 11, 2019

Added new version. Tested. Rebased to latest release 18.09

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 11, 2019

We usually add packages to master first and then backport them as needed.

@petrkr

This comment has been minimized.

Copy link
Author

petrkr commented Mar 11, 2019

We usually add packages to master first and then backport them as needed.

How to do ? Rebase to master?

@petrkr petrkr changed the base branch from release-18.09 to master Mar 11, 2019
@petrkr

This comment has been minimized.

Copy link
Author

petrkr commented Mar 11, 2019

Rebased to master

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Mar 11, 2019

We typically don't have a /usr folder. Likely it should be fine to just move it's contents (share) directly into $out.

@petrkr

This comment has been minimized.

Copy link
Author

petrkr commented Mar 11, 2019

This software is custom made and it's somehow magic it works in NixOS where nothing is on standard paths. I can try move it outside of it, but they have lot's of hard-coded. Anyway it's not actual now because my collage already installed that software through WINE.

so now it's only nice2have.

@petrkr

This comment has been minimized.

Copy link
Author

petrkr commented Mar 15, 2019

Moved usr/share to root of package. Moved usr/bin to bin as hidden with postfix -wrapped (as makewrapper do). Rebased to latest master. Tested - works fine

@petrkr petrkr closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.