Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-generate-config: add rudimentary high-DPI detection #56337

Merged
merged 1 commit into from May 15, 2019

Conversation

@lheckemann
Copy link
Member

lheckemann commented Feb 25, 2019

Motivation for this change

#12345

I've tested that the generated config seems to make sense, but not built it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann

This comment has been minimized.

Copy link
Member Author

lheckemann commented May 14, 2019

@GrahamcOfBorg test installer

@lheckemann lheckemann force-pushed the mayflower:hidpi-console branch from 7caa03c to 89b64ab May 15, 2019
@lheckemann

This comment has been minimized.

Copy link
Member Author

lheckemann commented May 15, 2019

I've now built and tested a configuration on my laptop, which has a high-DPI monitor. So I'll go ahead and merge this.

@lheckemann lheckemann merged commit 8ec48dc into NixOS:master May 15, 2019
@lheckemann lheckemann deleted the mayflower:hidpi-console branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.