Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] wget: 1.19.5 -> 1.20.1 #56375

Merged
merged 2 commits into from Feb 27, 2019
Merged

[18.09] wget: 1.19.5 -> 1.20.1 #56375

merged 2 commits into from Feb 27, 2019

Conversation

@tokudan
Copy link
Contributor

tokudan commented Feb 25, 2019

Motivation for this change

fixes #56372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dtzWill and others added 2 commits Nov 30, 2018
@xeji xeji changed the title wget: 1.19.5 -> 1.20.1 [18.09] wget: 1.19.5 -> 1.20.1 Feb 25, 2019
@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Feb 25, 2019

Hmm, I see the original approach wasn't finished/merged: #52979

@tokudan

This comment has been minimized.

Copy link
Contributor Author

tokudan commented Feb 25, 2019

@vcunat Looks like it's quite complicated to backport the change to the old version.
Considering the changes in wget between 1.19.5 to 1.20.1 I don't think it's really worth it and just moving to the new version is probably a lot easier: http://git.savannah.gnu.org/cgit/wget.git/tree/NEWS

@vcunat
vcunat approved these changes Feb 27, 2019
Copy link
Member

vcunat left a comment

NEWS really do seem "safe".

@vcunat vcunat merged commit 022a6f7 into NixOS:release-18.09 Feb 27, 2019
10 checks passed
10 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vcunat added a commit that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.