Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: init at 5.6.0 #56379

Merged
merged 1 commit into from Feb 25, 2019

Conversation

@aanderse
Copy link
Contributor

aanderse commented Feb 25, 2019

Motivation for this change

Wasn't yet packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Feb 25, 2019

@GrahamcOfBorg build php71Packages.sqlsrv php72Packages.sqlsrv php73Packages.sqlsrv php71Packages.pdo_sqlsrv php72Packages.pdo_sqlsrv php73Packages.pdo_sqlsrv

@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Feb 25, 2019

@etu What do you think? Merge it in real quick before we freeze? 😄

@etu etu merged commit 18c70f9 into NixOS:master Feb 25, 2019
12 checks passed
12 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
php71Packages.pdo_sqlsrv, php71Packages.sqlsrv, php72Packages.pdo_sqlsrv, php72Packages.sqlsrv, php73Packages.pdo_sqlsrv, php73Packages.sqlsrv on aarch64-linux Success
Details
php71Packages.pdo_sqlsrv, php71Packages.sqlsrv, php72Packages.pdo_sqlsrv, php72Packages.sqlsrv, php73Packages.pdo_sqlsrv, php73Packages.sqlsrv on x86_64-linux Success
Details
@etu

This comment has been minimized.

Copy link
Contributor

etu commented Feb 25, 2019

@aanderse Sneaky there! :-)

@aanderse aanderse deleted the aanderse:php-sqlsrv branch Feb 25, 2019
@etu

This comment has been minimized.

Copy link
Contributor

etu commented Feb 26, 2019

@aanderse But we seem to have missed the window :(

@aanderse

This comment has been minimized.

Copy link
Contributor Author

aanderse commented Feb 26, 2019

@etu that's alright. This change is pretty low impact so I'll try for a 19.03 backport sometime after 19.03 is released.

Thanks again!

@etu etu mentioned this pull request Apr 12, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.