Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: 2.58.2 -> 2.58.3 #56385

Merged
merged 1 commit into from Feb 26, 2019
Merged

glib: 2.58.2 -> 2.58.3 #56385

merged 1 commit into from Feb 26, 2019

Conversation

@hedning
Copy link
Contributor

@hedning hedning commented Feb 25, 2019

Motivation for this change

closes #55999

Just targeting master to get reliable builds on all the platforms, will change to staging afterwards (so don't merge before that).

Things done
  • Built on platforms:
    • x86_64-linux
    • x86_64-darwin
    • aarch64-linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Drop patches that are now upstream.
@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Feb 26, 2019

Interesting Darwin failure on staging (unrelated to PR, of course)

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 26, 2019

That one should be fixed by 18fe630 – let me merge staging-next to staging to get rid of that :-)

@hedning
Copy link
Contributor Author

@hedning hedning commented Feb 26, 2019

Double checked that there isn't any outstanding bugs open for 2.58.3 which we should backport, and couldn't find any. So I'm going to merge.

@hedning hedning merged commit 295443b into NixOS:staging Feb 26, 2019
13 checks passed
@hedning hedning deleted the glib-bump-version branch Feb 26, 2019
hedning added a commit to hedning/nixpkgs that referenced this issue Apr 2, 2019
Drop patches that are now upstream.

(cherry picked from commit 295443b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants