Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-runner: 11.7.0 -> 11.8.0 #56388

Merged
merged 1 commit into from Feb 26, 2019
Merged

gitlab-runner: 11.7.0 -> 11.8.0 #56388

merged 1 commit into from Feb 26, 2019

Conversation

@bachp
Copy link
Contributor

bachp commented Feb 25, 2019

Motivation for this change

https://gitlab.com/gitlab-org/gitlab-runner/blob/4745a6f306741f29931ff5d549d1f6c46becfc71/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 26, 2019

@GrahamcOfBorg build gitlab-runner

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 26, 2019

Darwin failure looks unrelated.

@xeji xeji merged commit 23846b9 into NixOS:master Feb 26, 2019
13 checks passed
13 checks passed
gitlab-runner on x86_64-darwin Failure
Details
gitlab-runner on aarch64-linux Success
Details
gitlab-runner on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bachp bachp deleted the bachp:gitlab-runner-11.8.0 branch Feb 26, 2019
fpletz added a commit that referenced this pull request Mar 2, 2019
(cherry picked from commit 23846b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.