Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jazzy: 0.9.0 -> 0.9.5 #56399

Merged
merged 1 commit into from Mar 7, 2019
Merged

jazzy: 0.9.0 -> 0.9.5 #56399

merged 1 commit into from Mar 7, 2019

Conversation

@lilyball
Copy link
Member

@lilyball lilyball commented Feb 26, 2019

Motivation for this change

Updates the jazzy package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @peterromfeldhk

I had to update the update script. I did not make it match what we settled on with cocoapods because asking bundler to build and install all the packages was actually problematic (not only is it completely unnecessary but I ran into a problem with it depending on sqlite). So instead we just ask bundler to generate the lockfile and let bundix do its work and it works just fine. Next time cocoapods is updated we should probably update its update script again to match.

@lilyball
Copy link
Member Author

@lilyball lilyball commented Mar 6, 2019

What does it take to get package updates processed?

Also add myself as a maintainer.
@lilyball
Copy link
Member Author

@lilyball lilyball commented Mar 6, 2019

I've updated the commit to add myself as a maintainer of the package as well, as @peterromfeldhk does not seem to be particularly responsive.

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 7, 2019

@GrahamcOfBorg build jazzy

@ryantm ryantm merged commit 5b4152a into NixOS:master Mar 7, 2019
13 checks passed
@lilyball lilyball deleted the jazzy branch Mar 8, 2019
@peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Mar 14, 2019

@lilyball
Copy link
Member Author

@lilyball lilyball commented Mar 14, 2019

@peterromfeldhk As the listed maintainer you should at least approve (or reject) the change.

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 14, 2019

@peterromfeldhk You could use https://github.com/Mic92/nix-review nix-review pr 56399 to build and test this commit and see if it behaves the way you expect it to.

@peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Mar 14, 2019

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 14, 2019

Yes, a approval comment from the maintainer is very helpful. Once RFC 39 is implemented it will be possible for you to submit a approval review of PRs in GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants