Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackertyper: init at 1.1 #56401

Merged
merged 1 commit into from May 11, 2019
Merged

hackertyper: init at 1.1 #56401

merged 1 commit into from May 11, 2019

Conversation

@marius851000
Copy link
Contributor

@marius851000 marius851000 commented Feb 26, 2019

Motivation for this change

Wanted to test this and train at package creation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@etu etu left a comment

Some small changes suggested, good start for the first package 👍

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
@marius851000 marius851000 force-pushed the hackertyper branch 2 times, most recently from b05127e to c6cf40e Feb 27, 2019
@marius851000
Copy link
Contributor Author

@marius851000 marius851000 commented Feb 27, 2019

Ok, I finished to correct the error. Thank etu

pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/hackertyper/default.nix Outdated Show resolved Hide resolved
@dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 1, 2019

Hash is wrong, probably wasn't updated when moving from 1.1 to the latest git. Or however it happened, it seems wrong now--nix-prefetch-url -A hackertyper.src from your nixpkgs source tree will produce the correct hash.

@Lassulus
Copy link
Member

@Lassulus Lassulus commented Apr 27, 2019

Could we rebase this on the current master? merging it now would result in a dual entry in the maintainer-list.nix

etu
etu approved these changes May 7, 2019
@Lassulus Lassulus merged commit 8ce538a into NixOS:master May 11, 2019
13 checks passed
@marius851000 marius851000 deleted the hackertyper branch May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants