Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emscripten: 1.37.36 -> 1.38.28 #56406

Merged
merged 1 commit into from Apr 18, 2019
Merged

Conversation

@TomSmeets
Copy link
Contributor

@TomSmeets TomSmeets commented Feb 26, 2019

Motivation for this change

The 1.37.36 version is almost a year old.

Issues

When running nox-review wip the only package that fails is meguca. Maybe just updating this package could help. @Chiiruno

Things done

Tested with a personal project.
Build everything in emscriptenPackages

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@qknight
Copy link
Member

@qknight qknight commented Feb 26, 2019

if emscriptenPackages build this looks good and can be merged when done.

@TomSmeets TomSmeets marked this pull request as ready for review Feb 26, 2019
@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Feb 26, 2019

I will update my package(s) tomorrow, today isn't good.
Thanks for the heads up!

@TomSmeets
Copy link
Contributor Author

@TomSmeets TomSmeets commented Mar 10, 2019

Did you manage to update your package meguca @Chiiruno ?

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 10, 2019

No, I completely forgot.
I'll update now, since I have time.

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 10, 2019

Depends on bakape/meguca#999

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 12, 2019

I get this error with 1.37.36, may change with this update, will test.

too long and irrelevant

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 12, 2019

I get the same(?) error with 1.38.28.

mkdir -p www/wasm
make -C client_cpp
make[1]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp'
rm -f *.wasm *.wast *.js *.wasm.map *.js
make -C brunhild
make[2]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
emcc view.cc -o view.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc util.cc -o util.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc mutations.cc -o mutations.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc node.cc -o node.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc events.cc -o events.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc init.cc -o init.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: mutations.bc] Error 1
make[2]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: node.bc] Error 1
make[2]: *** [Makefile:10: util.bc] Error 1
make[2]: *** [Makefile:10: init.bc] Error 1
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: events.bc] Error 1
make[2]: *** [Makefile:10: view.bc] Error 1
make[2]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
make[1]: *** [Makefile:21: all] Error 2
make[1]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:26: wasm] Error 2
builder for '/nix/store/d6fgx0mxy2040s0bsq2cdd8x37ljannn-meguca-unstable-2019-03-12.drv' failed with exit code 2
error: build of '/nix/store/d6fgx0mxy2040s0bsq2cdd8x37ljannn-meguca-unstable-2019-03-12.drv' failed

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 12, 2019

Any thoughts on this @bakape?
Might be a meguca problem, but not sure.

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 12, 2019

Okay, I fixed the homeless-shelter thing again, different error with this commit's emscripten.

mkdir -p www/wasm
make -C client_cpp
make[1]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp'
rm -f *.wasm *.wast *.js *.wasm.map *.js
make -C brunhild
make[2]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
emcc view.cc -o view.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc util.cc -o util.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc mutations.cc -o mutations.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc node.cc -o node.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc events.cc -o events.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc init.cc -o init.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emscripten:INFO: generating system asset: is_vanilla.txt... (this will be cached in "/build/.emscripten_cache/is_vanilla.txt" for subsequent builds)
emscripten:INFO:  - ok
In file included from node.cc:1:
In file included from ./node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: node.bc] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from view.cc:1:
In file included from ./view.hh:3:
In file included from ./events.hh:3:
In file included from ./../src/../brunhild/node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: view.bc] Error 1
In file included from events.cc:1:
In file included from ./events.hh:3:
In file included from ./node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: events.bc] Error 1
make[2]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
make[1]: *** [Makefile:21: all] Error 2
make[1]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:26: wasm] Error 2
builder for '/nix/store/p5kap6knai1r54hm9rjca5bpjhpdpklk-meguca-unstable-2019-03-12.drv' failed with exit code 2
error: build of '/nix/store/p5kap6knai1r54hm9rjca5bpjhpdpklk-meguca-unstable-2019-03-12.drv' failed

@Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Mar 12, 2019

Okay interesting, emscripten compiles meguca on 1.37.36, but not on this commit.

@bakape
Copy link

@bakape bakape commented Mar 12, 2019

@TomSmeets
Copy link
Contributor Author

@TomSmeets TomSmeets commented Apr 18, 2019

Can this be merged?

@matthewbauer matthewbauer merged commit f0cba0b into NixOS:master Apr 18, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants