New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding railcar container module #56411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, a disclosure for other reviewers: I helped a bit with the development of this, especially in the initial exploration. With that in mind, I'm giving feedback on the code, but I won't be merging this, nor making any judgement about whether this should be in nixpkgs (though I'd hope it won't be controversial). I'll leave that to a fresh pair of eyes.
As for this review, it's mostly little niggly style stuff. There are a lot of comments but they're pretty trivial and nothing to worry about. :)
6cf6aaa
to
967f843
Compare
cc132c1
to
dee4776
Compare
@GrahamcOfBorg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some updates regarding documentation.
b23640a
to
bea458f
Compare
I updated the documentation according to the given advice. I also ended up removing |
bea458f
to
4acccb0
Compare
4acccb0
to
2046d1c
Compare
This has been open for ages, and nobody has had any concerns, so I'm going to merge this in a couple of days if nothing comes up before then. |
Woops |
2046d1c
to
574480d
Compare
Ping @alyssais I changed the |
I'm slightly unsure if having mounts be a list of attrsets is the right move… it's tempting to mirror the NixOS |
I'm looking forward to see ociTools within Nix. |
e5ccb32
to
db8b81e
Compare
Alright, it's been a while but I finally made some progress on this Mounts into an OCI container now use a similar declarative structure as I kinda wanted to add a test for all this, but couldn't figure out how to make that work. I'd love to add one later, but also kinda just wanna see this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny style things. We’re so close!!
9c49015
to
d8b7b8f
Compare
Motivation for this change
The OCI container spec describes a simple way of creating a container with a
config.json
and arootfs
. These containers can be run by a container runner (such asrunc
orrailcar
) without having to rely on a daemon to manage containers outside of a NixOS config.This PR adds two things
I also added documentation to the manual to explain how to use the underlying container-building function, so that other container runner modules can be added down the line.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)