Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/jupyter: Fix documentation example for jupyter.kernels #56413

Closed
wants to merge 2,195 commits into from

Conversation

@BenSchZA
Copy link
Contributor

@BenSchZA BenSchZA commented Feb 26, 2019

Motivation for this change

The environment variable loading fails when using the example for kernels config, due to incorrect syntax. The error being something along the lines of path not found. The same is true for the loading of the relevant icons from path.

This change is a simple update of the service documentation.

Things done
  • Built on platform(s)
    • NixOS
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
worldofpeace and others added 30 commits Jan 21, 2019
(cherry picked from commit f15aecd)
(cherry picked from commit 3f634dd)
(cherry picked from commit fad6b01)
ghc needs it to fail to correctly detect it for later.
(cherry picked from commit 70b8ab6)
(cherry picked from commit fdc6caf)
This removes the 1.29 backport and replaces it with the 1.31 version
from master.
jemalloc with stripped prefix would cause segfaults in free:
NixOS#49557 (comment)

This commit has been adjusted from the one on master to only carry the
relevant changes (the new optional `stripPrefix`) flag while still
keeping the other flags that were removed on master since they are no
loner supported by the version used there.

(cherry picked from commit 973eca7)
Firefox >=65 will depend on icu >=63. All the older firefox versions
(and derived packages) seem to work fine with this change.

Also the system path environment patch will fail to apply since there
was a trivial whitespace change in the source file. By adding `-l` to
patch we can avoid having to track two patches that do basically the
same. Having patchFlags per file without resorting to pre-/postPatch
would be nicer but there doesn't seem to be a facility for that right
now.

(cherry picked from commit e37b765e7897c015153552d4e33a8571ab9c5457)
(cherry picked from commit 2a858b3)
haskellPackages.pandoc-crossref: refactor disable tests for 0.3.2.1 [backport]
(cherry picked from commit 8ee43e0)
(cherry picked from commit 5f0a4ee)
(cherry picked from commit 1b8beae)
v6.1-20181027 url is 404.

(cherry picked from commit 138720f)
Development releases of ncurses are uploaded but often also removed
again. This is causing a lot of trouble, so let's instead use a
GitHub mirror.

(cherry picked from commit 43e867a)
(cherry picked from commit 11cf7d6)
This makes its behaviour conform to what is implied in the
documentation.
This makes its behaviour conform to what is implied in the
documentation.

(cherry picked from commit 6f05dea)
[18.09] buildFHSUserEnv: use runScript in env
This reverts commit 5574df3.
I also can't reproduce the problem anymore; discussion: NixOS#41312.
Fixes NixOS#53569, fixes NixOS#53948.  (Vulnerabilities in old curl.)

(cherry picked from commit 51ac3db)
I've noticed no complaints about this change on unstable/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment