Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install llpp.inotify #56422

Merged
merged 2 commits into from Feb 28, 2019
Merged

Install llpp.inotify #56422

merged 2 commits into from Feb 28, 2019

Conversation

@pSub
Copy link
Member

@pSub pSub commented Feb 26, 2019

Motivation for this change
  • Removes unused lib/ directory
  • Adds llpp.inotify script to bin/. This script is a wrapper that provides automatic reloading on file modifications via inotify.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub pSub merged commit ecaa658 into master Feb 28, 2019
12 checks passed
Loading
@pSub pSub deleted the install-llpp.inotify branch Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants