Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit: add service unit and update package #56423

Merged
merged 2 commits into from Mar 20, 2019
Merged

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Feb 26, 2019

Motivation for this change

Add systemd service to use Unit App Server.
Update package to 1.8.0
Used patch to enable work with unprivileged user - nginx/unit#228

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin requested a review from Infinisil as a code owner Feb 26, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Feb 26, 2019

@Izorkin Izorkin force-pushed the nginx-unit branch 2 times, most recently from af7beba to bb7f3e9 Mar 2, 2019
@Izorkin Izorkin changed the title unit: add service unit unit: add service unit and update package Mar 2, 2019
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
@aanderse aanderse mentioned this pull request Mar 5, 2019
10 tasks
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-servers/unit/default.nix Outdated Show resolved Hide resolved
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Mar 8, 2019

Enable rootless mode. Please recheck.

nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin force-pushed the nginx-unit branch 2 times, most recently from 771e8bd to 28fd979 Mar 9, 2019
@Izorkin
Copy link
Contributor Author

@Izorkin Izorkin commented Mar 9, 2019

Squashed commits.

@disassembler disassembler merged commit cafd07a into NixOS:master Mar 20, 2019
12 checks passed
@Izorkin Izorkin deleted the nginx-unit branch Mar 20, 2019
@xeji xeji mentioned this pull request Mar 27, 2019
@aanderse aanderse mentioned this pull request Apr 22, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants