Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmonad-with-packages: add xmonad-contrib to packages by default #56426

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@catern
Copy link
Contributor

@catern catern commented Feb 26, 2019

This is more newbie-friendly; a user without much Nix knowledge would
"nix search" for xmonad, see xmonad-with-packages, and just
immediately install it. This basically never works because most xmonad
users use xmonad-contrib. If we add xmonad-contrib to the packages
list for xmonad by default, then the new user's straightforward action
will just work, most of the time.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is more newbie-friendly; a user without much Nix knowledge would
"nix search" for xmonad, see xmonad-with-packages, and just
immediately install it. This basically never works because most xmonad
users use xmonad-contrib. If we add xmonad-contrib to the packages
list for xmonad by default, then the new user's straightforward action
will just work, most of the time.
@srhb
Copy link
Contributor

@srhb srhb commented Feb 26, 2019

On the other hand, this confuses things when compared to the xmonad NixOS-options: https://nixos.org/nixos/options.html#enablecontrib

@catern
Copy link
Contributor Author

@catern catern commented Feb 26, 2019

Perhaps that option could be renamed and repurposed to enableExtras? Or, it could be left as it is - AFAIK there's no downside to having a library occur in buildInputs twice.

Copy link
Member

@Infinisil Infinisil left a comment

Looks good to me, xmonad isn't very useful without -contrib anyways

@Infinisil Infinisil merged commit 2dd638e into NixOS:master Mar 14, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants