Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hueadm: init at 1.2.0 #56444

Merged
merged 1 commit into from Feb 27, 2019
Merged

hueadm: init at 1.2.0 #56444

merged 1 commit into from Feb 27, 2019

Conversation

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Feb 26, 2019

Motivation for this change

hue-cli is not being updated anymore, the author is instead working on a new and improved version, hueadm.

Ping @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@samueldr samueldr left a comment

I have a hue bridge, and this works.

fpletz
fpletz approved these changes Feb 27, 2019
Copy link
Member

@fpletz fpletz left a comment

Looking good. I'm not using hue-cli anymore though. Should we remove it?

@Infinisil
Copy link
Member Author

@Infinisil Infinisil commented Feb 27, 2019

@fpletz I also thought about removing hue-cli, but I found this where @bahamas10 mentions that "hue-cli is here to stay".

@fpletz fpletz merged commit d4e5cb8 into NixOS:master Feb 27, 2019
13 checks passed
@Infinisil Infinisil deleted the add/hueadm branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants